Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1162] Remove duplicated SubtreeRoot #1163

Conversation

LukasKorba
Copy link
Collaborator

@LukasKorba LukasKorba commented Jul 21, 2023

Closes #1162

  • SubtreeRoot placeholder removed, we can rely on the generated one from the gprc

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
  • Automated tests: Did you add appropriate automated tests for any code changes?
  • Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
  • Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
  • Run the app: Did you run the app and try the changes?
  • Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
  • Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

  • Checklist review: Did you go through the code with the Code Review Guidelines checklist?
  • Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
  • Automated tests: Did you review the automated tests?
  • Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
  • How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
  • Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
  • Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

- SubtreeRoot placeholder removed, we can rely on the generated one from the gprc
@LukasKorba LukasKorba requested review from str4d and HonzaR July 21, 2023 11:53
@@ -158,7 +158,7 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/zcash-hackworks/zcash-light-client-ffi",
"state" : {
"revision" : "cdbc06f10b2d7cbe0d6362b30f68167825942e86"
"revision" : "57eb3bd4db3c26bf44d2d8d8b0d6f09f7602a125"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This revision is going to disappear when Electric-Coin-Company/zcash-light-client-ffi#94 gets rebased (to fix bugs, and use the final published crate versions once ready). As #1160 has already been merged, we can't change the revision that's in main, but we decided that we would just live with this revision going away (as the alternative is to add another 100+ MiB to the -ffi repo representing the buggy Rust state). So main is likely to break in the near term, but will be fixed with another PR update once the -ffi PR is finished and merged.

@str4d
Copy link
Collaborator

str4d commented Jul 21, 2023

The test failures are AFAICT unrelated to this PR, and are bugs caused by the Protobuf file updates in #1159 that weren't fixed there. A separate PR should be opened to fix them.

@str4d str4d merged commit 27b7e78 into Electric-Coin-Company:main Jul 21, 2023
1 check failed
@LukasKorba LukasKorba deleted the 1162-Remove-duplicated-SubtreeRoot branch August 31, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicated SubtreeRoot
2 participants